Issue 5651055: code review 5651055: cmd/go: fixed get's arbitrary server case to detect scheme.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5651055: code review 5651055: cmd/go: fixed get's arbitrary server case to detect scheme. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by eikeon

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/go: fixed get's arbitrary server case to detect scheme. Fixes issue 2895.

Patch Set 1 #

Patch Set 2 : diff -r 4a1b2d0d8450 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4a1b2d0d8450 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r caf7dca9d711 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ab8a2146f8f1 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -6 lines)			Patch
	M	src/cmd/go/vcs.go	View	1 2 3	10 chunks	+44 lines, -6 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

eikeon

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2012-02-10 04:20:02 UTC) #1

eikeon

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2012-02-10 15:07:22 UTC) #2

eikeon

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2012-02-13 16:21:44 UTC) #3

eikeon

On 2012/02/13 16:23:57, rsc wrote: > LGTM > > Thanks very much. Very welcome. I'll ...

13 years, 4 months ago (2012-02-13 19:38:00 UTC) #5

rsc

13 years, 4 months ago (2012-02-14 04:46:34 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=1cd9ea014a9e ***

cmd/go: go get scheme detection

Fixes issue 2895.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5651055

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages