Issue 5651051: code review 5651051: os: remove Time; callers should use time.Time.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5651051: code review 5651051: os: remove Time; callers should use time.Time. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by bradfitz

Modified:
13 years, 8 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

os: remove Time; callers should use time.Time. Part of issue 2947

Patch Set 2 : diff -r bd5f319dbd6e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bd5f319dbd6e https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r bd5f319dbd6e https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -35 lines)			Patch
M	doc/go1.html	View	1 2 3	1 chunk	+12 lines, -1 line	0 comments	Download
M	doc/go1.tmpl	View	1 2 3	1 chunk	+12 lines, -1 line	0 comments	Download
M	src/pkg/os/os_test.go	View	1	2 chunks	+0 lines, -14 lines	0 comments	Download
R	src/pkg/os/time.go	View	1	1 chunk	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2012-02-10 00:41:11 UTC) #1

LGTM http://codereview.appspot.com/5651051/diff/7/doc/go1.tmpl File doc/go1.tmpl (right): http://codereview.appspot.com/5651051/diff/7/doc/go1.tmpl#newcode1256 doc/go1.tmpl:1256: the <code>Time</code> type from the <code>time</code> package.</p> link ...

13 years, 8 months ago (2012-02-10 00:42:51 UTC) #2

bradfitz

13 years, 8 months ago (2012-02-10 00:44:58 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=89bf6c7e5674 ***

os: remove Time; callers should use time.Time.

Part of issue 2947

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5651051

Expand All Messages | Collapse All Messages