code review 5651049: dist: prevent recusive loop on windows when fatal() is ...

dist: prevent recusive loop on windows when fatal() is called.

Fixes issue 2931.

[kardia, 2012-02-09 23:27:46]

Hello golang-dev@googlegroups.com (cc: alex.brainman@gmail.com,
golang-dev@googlegroups.com, rsc@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2012-02-09 23:38:50]

Thank you.

Alex

http://codereview.appspot.com/5651049/diff/4001/src/cmd/dist/windows.c
File src/cmd/dist/windows.c (right):

http://codereview.appspot.com/5651049/diff/4001/src/cmd/dist/windows.c#newcod...
src/cmd/dist/windows.c:390: CloseHandle(bg[i].pi.hProcess);
Since i < 0 || i >= nbg, then i index is invalid here. So drop this part.

http://codereview.appspot.com/5651049/diff/4001/src/cmd/dist/windows.c#newcod...
src/cmd/dist/windows.c:400: CloseHandle(bg[i].pi.hProcess);
I don't like have 3 copies of same clean-up code. Not sure what is the cleanest
way. Maybe have new little function that takes index and closes handles and
adjust process table.

[kardia, 2012-02-09 23:54:17]

Hello golang-dev@googlegroups.com, alex.brainman@gmail.com (cc:
golang-dev@googlegroups.com, rsc@golang.org),

Please take another look.

[brainman, 2012-02-10 00:46:03]

LGTM.

It fixes the issue for me. Leaving for rsc to submit, perhaps there is more to
it.

Thank you, again.

Alex

[rsc, 2012-02-10 04:10:34]

*** Submitted as http://code.google.com/p/go/source/detail?r=28272c575625 ***

dist: prevent recusive loop on windows when fatal() is called.

Fixes issue 2931.

R=golang-dev, alex.brainman
CC=golang-dev, rsc
http://codereview.appspot.com/5651049

Committer: Russ Cox <rsc@golang.org>