Issue 5650078: code review 5650078: go/doc: don't loose exported consts/vars with unexporte...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5650078: code review 5650078: go/doc: don't loose exported consts/vars with unexporte... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by gri

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/doc: don't lose exported consts/vars with unexported type Fixes issue 2998.

Patch Set 1 #

Patch Set 2 : diff -r daf22f371d51 https://code.google.com/p/go #

Patch Set 3 : diff -r daf22f371d51 https://code.google.com/p/go #

Patch Set 4 : diff -r ae2ea46c2ba8 https://code.google.com/p/go #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -2 lines)			Patch
M	src/pkg/go/doc/reader.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/go/doc/testdata/b.go	View	1	2 chunks	+28 lines, -0 lines	0 comments	Download
M	src/pkg/go/doc/testdata/b.0.golden	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
M	src/pkg/go/doc/testdata/b.1.golden	View	1	1 chunk	+35 lines, -1 line	0 comments	Download
M	src/pkg/go/doc/testdata/b.2.golden	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

14 years, 5 months ago (2012-02-13 19:44:25 UTC) #1

gri

14 years, 5 months ago (2012-02-13 20:24:04 UTC) #4

*** Submitted as 4e8c247759c1 ***

go/doc: don't lose exported consts/vars with unexported type

Fixes issue 2998.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5650078

Expand All Messages | Collapse All Messages