Issue 5650076: code review 5650076: tools: Added support for LFENCE, MFENCE and SFENCE asse...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5650076: code review 5650076: tools: Added support for LFENCE, MFENCE and SFENCE asse...

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by darren

Modified:
13 years, 4 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

tools: Added support for LFENCE, MFENCE and SFENCE assembly ops to the 386 cmd code. (These assembly ops are already present in the amd64 cmd code). Added entries to the end of each array / enum

Patch Set 1 #

Patch Set 2 : diff -r 9d7addec2635 https://code.google.com/p/go #

Patch Set 3 : diff -r 9d7addec2635 https://code.google.com/p/go #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
M	src/cmd/8a/lex.c	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/cmd/8l/8.out.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/8l/optab.c	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

darren

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

13 years, 4 months ago (2012-02-13 18:29:17 UTC) #1

rsc

13 years, 4 months ago (2012-02-13 18:58:15 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a7756e3a5e71 ***

8a, 8l: add LFENCE, MFENCE, SFENCE

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5650076

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages