Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4054)

Issue 5650066: code review 5650066: cgo: add support for returning errno with gccgo. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by remyoudompheng
Modified:
12 years, 8 months ago
Reviewers:
CC:
golang-dev, albert.strasheim, iant, rsc, remy_archlinux.org
Visibility:
Public.

Description

cgo: add support for returning errno with gccgo. Also eliminate some warnings in builds.

Patch Set 1 #

Patch Set 2 : code review 5650066: cgo: add support for returning errno with gccgo. #

Patch Set 3 : diff -r f7aed2bd4786 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f7aed2bd4786 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 5ce1ea3ede7a https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 0158e2415ca5 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M src/cmd/cgo/out.go View 1 2 3 4 4 chunks +40 lines, -12 lines 0 comments Download
M src/cmd/go/build.go View 1 2 3 4 5 3 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 10
remyoudompheng
Hello iant@google.com, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 8 months ago (2012-02-12 10:26:53 UTC) #1
remyoudompheng
Hello iant@google.com, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.
12 years, 8 months ago (2012-02-12 12:16:45 UTC) #2
albert.strasheim
On 2012/02/12 12:16:45, remyoudompheng wrote: > Hello mailto:iant@google.com, mailto:golang-dev@googlegroups.com (cc: > mailto:golang-dev@googlegroups.com, mailto:remy@archlinux.org), > > ...
12 years, 8 months ago (2012-02-12 12:27:24 UTC) #3
iant
http://codereview.appspot.com/5650066/diff/3004/src/cmd/cgo/out.go File src/cmd/cgo/out.go (right): http://codereview.appspot.com/5650066/diff/3004/src/cmd/cgo/out.go#newcode279 src/cmd/cgo/out.go:279: fmt.Fprintf(fgo2, "\tr, errno := %s(%s)\n", cname, strings.Join(paramnames, ", ")) ...
12 years, 8 months ago (2012-02-12 19:17:29 UTC) #4
remyoudompheng
http://codereview.appspot.com/5650066/diff/3004/src/cmd/cgo/out.go File src/cmd/cgo/out.go (right): http://codereview.appspot.com/5650066/diff/3004/src/cmd/cgo/out.go#newcode279 src/cmd/cgo/out.go:279: fmt.Fprintf(fgo2, "\tr, errno := %s(%s)\n", cname, strings.Join(paramnames, ", ")) ...
12 years, 8 months ago (2012-02-13 22:15:43 UTC) #5
remyoudompheng
Hello iant@google.com, golang-dev@googlegroups.com, fullung@gmail.com, iant@golang.org (cc: golang-dev@googlegroups.com, remy@archlinux.org), Please take another look.
12 years, 8 months ago (2012-02-13 23:12:23 UTC) #6
iant2
FYI remyoudompheng@gmail.com writes: > That looks interesting. I can't find GetErrno in the standard Go ...
12 years, 8 months ago (2012-02-14 05:08:02 UTC) #7
iant
LGTM but see what rsc thinks
12 years, 8 months ago (2012-02-14 05:27:54 UTC) #8
rsc
LGTM Thanks very much for working on this.
12 years, 8 months ago (2012-02-14 16:25:52 UTC) #9
remyoudompheng
12 years, 8 months ago (2012-02-14 19:24:08 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=b330eb5c9e6c ***

cgo: add support for returning errno with gccgo.

Also eliminate some warnings in builds.

R=golang-dev, fullung, iant, rsc
CC=golang-dev, remy
http://codereview.appspot.com/5650066
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b