Issue 5649090: [google]Emit GNU-stack note for arm targets by default

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5649090: [google]Emit GNU-stack note for arm targets by default

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by jingyu

Modified:
9 years, 7 months ago

Reviewers:
davidxl

CC:
gcc-patches_gcc.gnu.org

Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/main/

Visibility:
Public.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	gcc/config/arm/arm.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jingyu

arm-eabi toolchain needs GNU-stack note for security purpose. Will Keep this patch in google branches. ...

12 years, 2 months ago (2012-02-14 19:34:45 UTC) #1

davidxl

12 years, 2 months ago (2012-02-14 19:38:50 UTC) #2

ok.

On Tue, Feb 14, 2012 at 11:34 AM, Jing Yu <jingyu@google.com> wrote:
> arm-eabi toolchain needs GNU-stack note for security purpose.
> Will Keep this patch in google branches.
>
> OK for google/main?
> I would like to port this patch to google/gcc-4_6, google/gcc-4_6-mobile,
> google/gcc-4_6_2-moible.
>
> 2012-02-14  Jing Yu  <jingyu@google.com>
>        Google ref 42402-p2
>        * config/arm/arm.h: Emit GNU-stack note for all arm targets by
>        default.
>
> Index: gcc/config/arm/arm.h
> ===================================================================
> --- gcc/config/arm/arm.h        (revision 184221)
> +++ gcc/config/arm/arm.h        (working copy)
> @@ -2157,9 +2157,9 @@
>    : arm_gen_return_addr_mask ())
>
>
> -/* Do not emit .note.GNU-stack by default.  */
> +/* Do emit .note.GNU-stack by default.  */
>  #ifndef NEED_INDICATE_EXEC_STACK
> -#define NEED_INDICATE_EXEC_STACK       0
> +#define NEED_INDICATE_EXEC_STACK       1
>  #endif
>
>  /* The maximum number of parallel loads or stores we support in an ldm/stm
>
> --
> This patch is available for review at http://codereview.appspot.com/5649090

Expand All Messages | Collapse All Messages