code review 5649089: syscall: linux Tgkill takes a Signal too

syscall: linux Tgkill takes a Signal too

[rsc, 2012-02-14 17:59:33]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2012-02-14 18:01:27]

LGTM

On Tue, Feb 14, 2012 at 9:59 AM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> syscall: linux Tgkill takes a Signal too
>
> Please review this at http://codereview.appspot.com/5649089/
>
> Affected files:
>  M src/pkg/syscall/syscall_linux.go
>  M src/pkg/syscall/zsyscall_linux_386.go
>  M src/pkg/syscall/zsyscall_linux_amd64.go
>  M src/pkg/syscall/zsyscall_linux_arm.go
>
>
> Index: src/pkg/syscall/syscall_linux.go
> ===================================================================
> --- a/src/pkg/syscall/syscall_linux.go
> +++ b/src/pkg/syscall/syscall_linux.go
> @@ -856,7 +856,7 @@
>  //sys  Sync()
>  //sysnb        Sysinfo(info *Sysinfo_t) (err error)
>  //sys  Tee(rfd int, wfd int, len int, flags int) (n int64, err error)
> -//sysnb        Tgkill(tgid int, tid int, sig int) (err error)
> +//sysnb        Tgkill(tgid int, tid int, sig Signal) (err error)
>  //sysnb        Times(tms *Tms) (ticks uintptr, err error)
>  //sysnb        Umask(mask int) (oldmask int)
>  //sysnb        Uname(buf *Utsname) (err error)
> Index: src/pkg/syscall/zsyscall_linux_386.go
> ===================================================================
> --- a/src/pkg/syscall/zsyscall_linux_386.go
> +++ b/src/pkg/syscall/zsyscall_linux_386.go
> @@ -793,7 +793,7 @@
>
>  // THIS FILE IS GENERATED BY THE COMMAND AT THE TOP; DO NOT EDIT
>
> -func Tgkill(tgid int, tid int, sig int) (err error) {
> +func Tgkill(tgid int, tid int, sig Signal) (err error) {
>        _, _, e1 := RawSyscall(SYS_TGKILL, uintptr(tgid), uintptr(tid),
> uintptr(sig))
>        if e1 != 0 {
>                err = e1
> Index: src/pkg/syscall/zsyscall_linux_amd64.go
> ===================================================================
> --- a/src/pkg/syscall/zsyscall_linux_amd64.go
> +++ b/src/pkg/syscall/zsyscall_linux_amd64.go
> @@ -793,7 +793,7 @@
>
>  // THIS FILE IS GENERATED BY THE COMMAND AT THE TOP; DO NOT EDIT
>
> -func Tgkill(tgid int, tid int, sig int) (err error) {
> +func Tgkill(tgid int, tid int, sig Signal) (err error) {
>        _, _, e1 := RawSyscall(SYS_TGKILL, uintptr(tgid), uintptr(tid),
> uintptr(sig))
>        if e1 != 0 {
>                err = e1
> Index: src/pkg/syscall/zsyscall_linux_arm.go
> ===================================================================
> --- a/src/pkg/syscall/zsyscall_linux_arm.go
> +++ b/src/pkg/syscall/zsyscall_linux_arm.go
> @@ -793,7 +793,7 @@
>
>  // THIS FILE IS GENERATED BY THE COMMAND AT THE TOP; DO NOT EDIT
>
> -func Tgkill(tgid int, tid int, sig int) (err error) {
> +func Tgkill(tgid int, tid int, sig Signal) (err error) {
>        _, _, e1 := RawSyscall(SYS_TGKILL, uintptr(tgid), uintptr(tid),
> uintptr(sig))
>        if e1 != 0 {
>                err = e1
>
>

[rsc, 2012-02-14 18:07:18]

*** Submitted as http://code.google.com/p/go/source/detail?r=550ed3989dbd ***

syscall: linux Tgkill takes a Signal too

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5649089