code review 5649074: builder: really set $GOBUILDEXIT for Windows

builder: really set $GOBUILDEXIT for Windows

[brainman, 2012-02-12 22:46:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc1, 2012-02-13 03:26:52]

LGTM
On Feb 12, 2012 5:46 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> builder: really set $GOBUILDEXIT for Windows
>
> Please review this at
http://codereview.appspot.com/**5649074/<http://codereview.appspot.com/5649074/>
>
> Affected files:
>  M misc/dashboard/builder/main.go
>
>
> Index: misc/dashboard/builder/main.go
> ==============================**==============================**=======
> --- a/misc/dashboard/builder/main.**go
> +++ b/misc/dashboard/builder/main.**go
> @@ -54,7 +54,7 @@
>        buildRelease  = flag.Bool("release", false, "Build and upload
> binary release archives")
>        buildRevision = flag.String("rev", "", "Build specified revision
> and exit")
>        buildCmd      = flag.String("cmd", filepath.Join(".", allCmd),
> "Build command (specify relative to go/src/)")
> -       failAll = flag.Bool("fail", false, "fail all builds")
> +       failAll       = flag.Bool("fail", false, "fail all builds")
>        external      = flag.Bool("external", false, "Build external
> packages")
>        parallel      = flag.Bool("parallel", false, "Build multiple
> targets in parallel")
>        verbose       = flag.Bool("v", false, "verbose")
> @@ -88,7 +88,7 @@
>                }
>                builders[i] = b
>        }
> -
> +
>        if *failAll {
>                failMode(builders)
>                return
> @@ -383,10 +383,10 @@
>        if hash == "" {
>                return false
>        }
> -
> +
>        log.Printf("fail %s %s\n", b.name, hash)
>
> -       if err := b.recordResult(false, "", hash, "", "auto-fail mode run
> by " + os.Getenv("USER"), 0); err != nil {
> +       if err := b.recordResult(false, "", hash, "", "auto-fail mode run
> by "+os.Getenv("USER"), 0); err != nil {
>                log.Print(err)
>        }
>        return true
> @@ -478,7 +478,6 @@
>                "GOOS=" + b.goos,
>                "GOARCH=" + b.goarch,
>                "GOROOT_FINAL=/usr/local/go",
> -               "GOBUILDEXIT=1", // On Windows, exit all.bat with
> completion status.
>        }
>        for _, k := range extraEnv {
>                s, err := os.Getenverror(k)
> @@ -496,7 +495,8 @@
>                "GOARCH":       b.goarch,
>                "GOROOT_FINAL": "/c/go",
>                // TODO(brainman): remove once we find make that does not
> hang.
> -               "MAKEFLAGS": "-j1",
> +               "MAKEFLAGS":   "-j1",
> +               "GOBUILDEXIT": "1", // exit all.bat with completion status.
>        }
>        for _, name := range extraEnv {
>                s, err := os.Getenverror(name)
>
>
>

[brainman, 2012-02-13 03:32:51]

*** Submitted as http://code.google.com/p/go/source/detail?r=676788f0eb7f ***

builder: really set $GOBUILDEXIT for Windows

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5649074

[brainman, 2012-02-13 03:34:28]

On 2012/02/13 03:26:52, rsc1 wrote:
> LGTM

Will you update windows builders when you have time, please. Thank you.

Alex