code review 5649051: all.bat: report error code back to the gobuilder

all.bat: report error code back to the gobuilder

not sure that it will work, but.

[brainman, 2012-02-10 05:25:25]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-02-10 05:29:02]

LGTM

what's the worst that can happen?


On Fri, Feb 10, 2012 at 4:25 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> all.bat: report error code back to the gobuilder
>
> not sure that it will work, but.
>
> Please review this at
http://codereview.appspot.com/**5649051/<http://codereview.appspot.com/5649051/>
>
> Affected files:
>  M src/all.bat
>
>
> Index: src/all.bat
> ==============================**==============================**=======
> --- a/src/all.bat
> +++ b/src/all.bat
> @@ -16,3 +16,4 @@
>  ..\bin\tool\dist banner
>
>  :end
> +exit %GOBUILDFAIL%
>
>
>

[brainman, 2012-02-10 05:29:57]

*** Submitted as http://code.google.com/p/go/source/detail?r=bbb1856e41e2 ***

all.bat: report error code back to the gobuilder

not sure that it will work, but.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5649051

[brainman, 2012-02-10 05:32:55]

On 2012/02/10 05:29:02, bradfitz wrote:
> 
> what's the worst that can happen?
> 

That is the attitude! Are you having beer yet?

The worst that can happens, the builder will say OK again. I want it to break.
And I am not joking this time.

Alex

[rsc, 2012-02-10 05:44:52]

LGTM

If I run all.bat at a command prompt now, does this make the command prompt
exit?  I've never understood when exit does that and when it doesn't.

[brainman, 2012-02-10 05:53:33]

On 2012/02/10 05:44:52, rsc wrote:
> If I run all.bat at a command prompt now, does this make the command prompt
> exit?  I've never understood when exit does that and when it doesn't.

This is how it works here:

exit 1: returns exit code 1 and does exits command prompt

exit /b 1: returns exit code 0 and exits command prompt

Neither is what we want. Is it?

Alex

[rsc, 2012-02-10 06:00:42]

On Fri, Feb 10, 2012 at 00:53,  <alex.brainman@gmail.com> wrote:
> This is how it works here:
>
> exit 1: returns exit code 1 and does exits command prompt
>
> exit /b 1: returns exit code 0 and exits command prompt
>
> Neither is what we want. Is it?

No.  Maybe the builder should set an environment
variable like GOBUILDEXIT=1.

if x%GOBUILDEXIT%==x1 exit %GOBUILDFAIL%

?

[brainman, 2012-02-10 06:04:19]

On 2012/02/10 06:00:42, rsc wrote:
> ...  Maybe the builder should set an environment
> variable like GOBUILDEXIT=1.
> 
> if x%GOBUILDEXIT%==x1 exit %GOBUILDFAIL%
> 

Sounds like a plan. But let me try something else first. I will let you know.

Alex

[brainman, 2012-02-10 06:19:08]

No, I have no alternative. So it is your way. Would you like me to send a CL.
You would have to update builders before we run it anyway.

Alex

[rsc, 2012-02-10 06:19:58]

On Fri, Feb 10, 2012 at 01:19,  <alex.brainman@gmail.com> wrote:
> No, I have no alternative. So it is your way. Would you like me to send
> a CL. You would have to update builders before we run it anyway.

I will send you a builder CL if you send me an all.bat CL.

[brainman, 2012-02-10 06:21:35]

On 2012/02/10 06:19:58, rsc wrote:
> 
> I will send you a builder CL if you send me an all.bat CL.

Why no one CL?

Alex

[rsc, 2012-02-10 06:22:32]

On Fri, Feb 10, 2012 at 01:21,  <alex.brainman@gmail.com> wrote:
> Why no one CL?

ok