Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
LGTM http://codereview.appspot.com/5647063/diff/3002/src/sudo.bash File src/sudo.bash (right): http://codereview.appspot.com/5647063/diff/3002/src/sudo.bash#newcode19 src/sudo.bash:19: Please use eval $(go tool dist env) http://codereview.appspot.com/5647063/diff/3002/src/sudo.bash#newcode26 src/sudo.bash:26: sudo cp ../pkg/tool/${GOOS}_$GOARCH/$i /usr/local/bin/go$i And then here, cp $GOTOOLDIR/$i /usr/local/bin/go$i I'm trying to keep the number of things that actually know where the tool directory is to a minimum.
*** Submitted as http://code.google.com/p/go/source/detail?r=14c8f376e8aa *** build: fix sudo.bash. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5647063 http://codereview.appspot.com/5647063/diff/3002/src/sudo.bash File src/sudo.bash (right): http://codereview.appspot.com/5647063/diff/3002/src/sudo.bash#newcode19 src/sudo.bash:19: On 2012/02/14 15:16:28, rsc wrote: > Please use > > eval $(go tool dist env) Done. http://codereview.appspot.com/5647063/diff/3002/src/sudo.bash#newcode26 src/sudo.bash:26: sudo cp ../pkg/tool/${GOOS}_$GOARCH/$i /usr/local/bin/go$i On 2012/02/14 15:16:28, rsc wrote: > And then here, cp $GOTOOLDIR/$i /usr/local/bin/go$i > I'm trying to keep the number of things that actually know > where the tool directory is to a minimum. Done.
