code review 5646066: misc/bash: Completion for go tool.

misc/bash: Completion for go tool.

This covers most of the tool's functionality. At some point,
support should probably be added for testflags and the various go
tools.

[DeedleFake, 2012-02-09 14:55:00]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[DeedleFake, 2012-02-26 17:17:33]

On 2012/02/09 14:55:00, DeedleFake wrote:
> Hello mailto:golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://code.google.com/p/go

ping

[bradfitz, 2012-02-27 00:50:44]

On Mon, Feb 27, 2012 at 4:17 AM, <Yissakhar.Beck@gmail.com> wrote:

> On 2012/02/09 14:55:00, DeedleFake wrote:
>
>> Hello mailto:golang-dev@**googlegroups.com <golang-dev@googlegroups.com>,
>>
>
>  I'd like you to review this change to
>> https://code.google.com/p/go
>>
>
> ping
>
>
http://codereview.appspot.com/**5646066/<http://codereview.appspot.com/5646066/>
>

The code seems sane, but I'm the last person who could be considered a
shell/bash reviewer.

If anybody else could review this and is happy with it (that it's at least
forward progress and isn't flat out wrong, even if it's still incomplete),
then I'm happy submitting it.  I realize that this might take a few commits
until it's polished.

- Brad

[Kyle E. Lemons, 2012-02-27 01:21:10]

LGTM

The `else` inside the build) case baffles me a bit, and this is way more
advanced than any of the completion I've done myself, but it all looks sound to
me.

[bradfitz, 2012-02-27 06:35:01]

$ hg clpatch 5646066
warning: cannot find yissakhar.beck@gmail.com in CONTRIBUTORS

Yissakhar.Beck, you'll need to submit a CLA before we can accept a patch:

See: http://golang.org/doc/contribute.html#copyright

Let us know when you have.


On Mon, Feb 27, 2012 at 12:21 PM, <kyle@kylelemons.net> wrote:

> LGTM
>
> The `else` inside the build) case baffles me a bit, and this is way more
> advanced than any of the completion I've done myself, but it all looks
> sound to me.
>
>
http://codereview.appspot.com/**5646066/<http://codereview.appspot.com/5646066/>
>

[DeedleFake, 2012-02-27 15:05:25]

On 2012/02/27 06:35:01, bradfitz wrote:
> $ hg clpatch 5646066
> warning: cannot find mailto:yissakhar.beck@gmail.com in CONTRIBUTORS
> 
> Yissakhar.Beck, you'll need to submit a CLA before we can accept a patch:
> 
> See: http://golang.org/doc/contribute.html#copyright
> 
> Let us know when you have.
> 
> 
> On Mon, Feb 27, 2012 at 12:21 PM, <mailto:kyle@kylelemons.net> wrote:
> 
> > LGTM
> >
> > The `else` inside the build) case baffles me a bit, and this is way more
> > advanced than any of the completion I've done myself, but it all looks
> > sound to me.
> >
> >
>
http://codereview.appspot.com/**5646066/%3Chttp://codereview.appspot.com/5646...>
> >

O.K., submitted.

[minux1, 2012-02-27 17:34:34]

http://codereview.appspot.com/5646066/diff/3001/misc/bash/go
File misc/bash/go (right):

http://codereview.appspot.com/5646066/diff/3001/misc/bash/go#newcode5
misc/bash/go:5: complete -f -X '!*.5' 5l
These lines are incorrect now, we now use 'go tool 8l' etc.

http://codereview.appspot.com/5646066/diff/3001/misc/bash/go#newcode6
misc/bash/go:6: complete -f -X '!*.go' 8g 6g 5g gofmt gccgo
ditto.

[bradfitz, 2012-02-27 20:41:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=7274b9ffeb86 ***

misc/bash: Completion for go tool.

This covers most of the tool's functionality. At some point,
support should probably be added for testflags and the various go
tools.

R=golang-dev, bradfitz, kyle, minux.ma
CC=golang-dev
http://codereview.appspot.com/5646066

Committer: Brad Fitzpatrick <bradfitz@golang.org>

[DeedleFake, 2012-02-27 20:59:28]

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org, kyle@kylelemons.net,
minux.ma@gmail.com),

Please take another look.

[DeedleFake, 2012-02-27 20:59:56]

On 2012/02/27 20:59:28, DeedleFake wrote:
> Hello mailto:golang-dev@googlegroups.com (cc: mailto:bradfitz@golang.org,
mailto:kyle@kylelemons.net,
> mailto:minux.ma@gmail.com),
> 
> Please take another look.

Oh. Woops. I didn't notice that it had submitted already. Sorry.

[bradfitz, 2012-02-27 21:01:27]

On Tue, Feb 28, 2012 at 7:59 AM, <Yissakhar.Beck@gmail.com> wrote:

> On 2012/02/27 20:59:28, DeedleFake wrote:
>
>> Hello mailto:golang-dev@**googlegroups.com <golang-dev@googlegroups.com>(cc:
>>
> mailto:bradfitz@golang.org, mailto:kyle@kylelemons.net,
>
>> mailto:minux.ma@gmail.com),
>>
>
>  Please take another look.
>>
>
> Oh. Woops. I didn't notice that it had submitted already. Sorry.
>
>
http://codereview.appspot.com/**5646066/<http://codereview.appspot.com/5646066/>
>

No problem.  Just mail a new CL if you want to continue to work on it.
 There's a correct size somewhere between tons of little incremental
changes (too noisy) and gigantic changes (too hard to review).