code review 5646053: cmd/dist: pass -m32 or -m64 to link too, not just compile

cmd/dist: pass -m32 or -m64 to link too, not just compile

[rsc, 2012-02-08 15:39:00]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2012-02-08 15:57:07]

LGTM

http://codereview.appspot.com/5646053/diff/2003/src/cmd/dist/build.c
File src/cmd/dist/build.c (right):

http://codereview.appspot.com/5646053/diff/2003/src/cmd/dist/build.c#newcode566
src/cmd/dist/build.c:566: vcopy(&link, gccargs.p+1, gccargs.len-1);
The -o can be the last option, you could do vcopy all of gccargs to link and
then add the -o, rather than doing [0] and then vcopy +1.

[rsc, 2012-02-08 16:11:27]

On Wed, Feb 8, 2012 at 10:57,  <iant@golang.org> wrote:
> The -o can be the last option, you could do vcopy all of gccargs to link
> and then add the -o, rather than doing [0] and then vcopy +1.

There's a note a few lines above: all the link commands
put the target in link.p[2].  I'll add a comment referring to that note.

Russ

[rsc, 2012-02-08 16:12:17]

*** Submitted as 13cd383941ad ***

cmd/dist: pass -m32 or -m64 to link too, not just compile

R=golang-dev, iant
CC=golang-dev
http://codereview.appspot.com/5646053