Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(766)

Issue 5645099: code review 5645099: all: update 'gotest' to 'go test' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by minux1
Modified:
13 years, 3 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

all: update 'gotest' to 'go test'

Patch Set 1 #

Patch Set 2 : diff -r 9d7addec2635 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9d7addec2635 https://go.googlecode.com/hg/ #

Total comments: 8

Patch Set 4 : diff -r 9d7addec2635 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M src/pkg/crypto/tls/handshake_client_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/crypto/tls/handshake_server_test.go View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M src/pkg/go/printer/performance_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/printer/printer.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/printer/printer_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/big/calibrate_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/math/big/nat.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/http/httptest/server.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/path/filepath/path_test.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/softfloat64.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/sync/mutex_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/sync/rwmutex_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
minux1
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 3 months ago (2012-02-13 18:22:07 UTC) #1
rsc
Thanks for fixing these. Let's use the shorter form of the flags. http://codereview.appspot.com/5645099/diff/4001/src/pkg/crypto/tls/handshake_client_test.go File src/pkg/crypto/tls/handshake_client_test.go ...
13 years, 3 months ago (2012-02-13 18:39:51 UTC) #2
minux1
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 3 months ago (2012-02-13 18:50:48 UTC) #3
rsc
LGTM Thanks.
13 years, 3 months ago (2012-02-13 18:55:07 UTC) #4
rsc
13 years, 3 months ago (2012-02-13 18:58:20 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=ce731433bb46 ***

all: update 'gotest' to 'go test'

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5645099

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b