Issue 5645088: code review 5645088: fix: add fix for crypto type change

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5645088: code review 5645088: fix: add fix for crypto type change (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, bradfitzgoog, r

Visibility:
Public.

Description

fix: add fix for crypto type change Fixes issue 2905.

Patch Set 2 : diff -r 8296cf56b8c1 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r c2f801cbd822 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 031625aa9500 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -8 lines)			Patch
A	src/cmd/fix/cryptotype.go	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
A	src/cmd/fix/cryptotype_test.go	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
M	src/cmd/fix/fix.go	View	1 2	3 chunks	+101 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2012-02-13 03:33:40 UTC) #1

bradfitzgoog

LGTM http://codereview.appspot.com/5645088/diff/1002/src/cmd/fix/fix.go File src/cmd/fix/fix.go (right): http://codereview.appspot.com/5645088/diff/1002/src/cmd/fix/fix.go#newcode779 src/cmd/fix/fix.go:779: OldImport string // only if this import is ...

13 years, 4 months ago (2012-02-13 03:41:58 UTC) #2

LGTM but, perhaps in another CL, use the rename for other tests. http://codereview.appspot.com/5645088/diff/1002/src/cmd/fix/cryptotype.go File src/cmd/fix/cryptotype.go ...

13 years, 4 months ago (2012-02-13 03:42:32 UTC) #3

rsc

13 years, 4 months ago (2012-02-13 21:01:37 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=f4b074d0f6aa ***

fix: add fix for crypto type change

Fixes issue 2905.

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/5645088

Expand All Messages | Collapse All Messages