code review 5645087: goprotobuf: start making it build with the go tool inst...

goprotobuf: start making it build with the go tool instead of make.
Work in progress.
This is sufficient to build, install, and test the proto library, and
to build and install the compiler plugin.
The tests for the plugin are disabled; they will require major work in a separate CL.

The compiler directory is now called protoc-gen-go so the binary has the right name.
The test.pb.go file for the proto tests is now checked in, for simplicity.

[r, 2012-02-11 04:53:08]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/goprotobuf

[r, 2012-02-13 02:06:13]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-02-13 02:50:37]

http://codereview.appspot.com/5645087/diff/5002/Makefile
File Makefile (right):

http://codereview.appspot.com/5645087/diff/5002/Makefile#newcode36
Makefile:36: cd proto && go install
I believe these can just be
  go install ./proto
  go install ./protoc-gen-go

The second depends on descriptor and plugin through imports.

http://codereview.appspot.com/5645087/diff/5002/Makefile#newcode42
Makefile:42: cd proto && go test
go test ./proto

http://codereview.appspot.com/5645087/diff/5002/Makefile#newcode47
Makefile:47: cd proto && go clean
go clean ...
should work, I think.

http://codereview.appspot.com/5645087/diff/5002/proto/testdata/golden_test.go
File proto/testdata/golden_test.go (right):

http://codereview.appspot.com/5645087/diff/5002/proto/testdata/golden_test.go...
proto/testdata/golden_test.go:46: func sum(name string, t *testing.T) string {
test helpers conventionally put the *testing.T arg first.

http://codereview.appspot.com/5645087/diff/5002/protoc-gen-go/Makefile
File protoc-gen-go/Makefile (right):

http://codereview.appspot.com/5645087/diff/5002/protoc-gen-go/Makefile#newcode35
protoc-gen-go/Makefile:35: cd testdata && go tool make test
isn't this line just
  cd testdata && make test
?

[r, 2012-02-13 03:01:18]

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-02-13 03:03:04]

LGTM

[r, 2012-02-13 03:25:37]

*** Submitted as be6d136a075a ***

goprotobuf: start making it build with the go tool instead of make.
Work in progress.
This is sufficient to build, install, and test the proto library, and
to build and install the compiler plugin.
The tests for the plugin are disabled; they will require major work in a
separate CL.

The compiler directory is now called protoc-gen-go so the binary has the right
name.
The test.pb.go file for the proto tests is now checked in, for simplicity.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5645087