Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(202)

Issue 5645086: code review 5645086: 8g: fix opt bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by rsc
Modified:
13 years, 4 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

8g: fix opt bug Was trying to optimize a duplicate float64 move by registerizing an int64. Fixes issue 2588.

Patch Set 1 #

Patch Set 2 : diff -r e5b29606a0b4 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a86581601fb2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M src/cmd/8g/reg.c View 1 2 chunks +4 lines, -1 line 0 comments Download
A test/fixedbugs/bug411.go View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2012-02-11 03:31:59 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=14d0aa739d81 *** 8g: fix opt bug Was trying to optimize a duplicate ...
13 years, 4 months ago (2012-02-11 03:32:04 UTC) #2
ken3
13 years, 4 months ago (2012-02-11 04:48:22 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b