Issue 5645072: [Issue 23] JSON Web Token (JWT) and JSON Web Signature (JWS)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5645072: [Issue 23] JSON Web Token (JWT) and JSON Web Signature (JWS) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by yanivi

Modified:
12 years, 2 months ago

Reviewers:
rmistry

Base URL:
https://google-oauth-java-client.googlecode.com/hg/

Visibility:
Public.

Description

[Issue 23] JSON Web Token (JWT) and JSON Web Signature (JWS) OpenID Connect Session Management

Patch Set 2 : fix copyright year #

Patch Set 3 : OpenID Connect Session Management #

Patch Set 6 : better deprecation comment #

Patch Set 7 : hg pull -u #

Total comments: 2

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+835 lines, -7 lines)			Patch
M	findbugs-exclude.xml	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	google-oauth-client-extensions/.settings/org.eclipse.jdt.ui.prefs	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	google-oauth-client/.settings/org.eclipse.jdt.ui.prefs	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/JsonWebSignature.java	View	1 2 3	1 chunk	+323 lines, -0 lines	0 comments	Download
A	google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/JsonWebToken.java	View	1	1 chunk	+315 lines, -0 lines	2 comments	Download
A	google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/package-info.java	View		1 chunk	+30 lines, -0 lines	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/TokenRequest.java	View	1 2 3	1 chunk	+7 lines, -1 line	0 comments	Download
M	google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/draft10/InstalledApp.java	View	1 2 3 4 5	1 chunk	+4 lines, -3 lines	0 comments	Download
A	google-oauth-client/src/main/java/com/google/api/client/auth/openidconnect/IdTokenResponse.java	View	1 2 3	1 chunk	+119 lines, -0 lines	0 comments	Download
A	google-oauth-client/src/main/java/com/google/api/client/auth/openidconnect/package-info.java	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rmistry

LGTM http://codereview.appspot.com/5645072/diff/8001/google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/JsonWebToken.java File google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/JsonWebToken.java (right): http://codereview.appspot.com/5645072/diff/8001/google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/JsonWebToken.java#newcode41 google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/JsonWebToken.java:41: * @param payload payload Remove javadoc if nothing ...

12 years, 2 months ago (2012-02-15 16:57:25 UTC) #3

yanivi

12 years, 2 months ago (2012-02-15 17:10:52 UTC) #4

http://codereview.appspot.com/5645072/diff/8001/google-oauth-client/src/main/...
File
google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/JsonWebToken.java
(right):

http://codereview.appspot.com/5645072/diff/8001/google-oauth-client/src/main/...
google-oauth-client/src/main/java/com/google/api/client/auth/jsontoken/JsonWebToken.java:41:
* @param payload payload
On 2012/02/15 16:57:25, rmistry wrote:
> Remove javadoc if nothing to add.

If you don't mind, I prefer to keep JavaDoc for parameters, even if it is not
helpful.

Expand All Messages | Collapse All Messages