Please review. Thanks! BTW: In some skia code, I've seen the assumption that SkScalar is ...
12 years, 10 months ago
(2012-02-09 06:55:01 UTC)
#1
Please review. Thanks!
BTW: In some skia code, I've seen the assumption that SkScalar is float, is this
assumption valid? Is there any place we still use SkFixed as SkScalar?
lgtm We still support a compile-time flag that makes SkScalar==SkFixed. This is not exercised by ...
12 years, 10 months ago
(2012-02-15 21:43:58 UTC)
#2
lgtm
We still support a compile-time flag that makes SkScalar==SkFixed. This is not
exercised by any (known) large clients, as android and chrome always build using
floats, but our internal tests and bots exercise both versions.
On 2012/02/15 21:43:58, reed1 wrote: > We still support a compile-time flag that makes SkScalar==SkFixed. ...
12 years, 10 months ago
(2012-02-16 05:58:20 UTC)
#3
On 2012/02/15 21:43:58, reed1 wrote:
> We still support a compile-time flag that makes SkScalar==SkFixed. This is not
> exercised by any (known) large clients, as android and chrome always build
using
> floats, but our internal tests and bots exercise both versions.
Thanks for your info.
And please help land this patch.
Issue 5645064: add explicit cast from SkScalar to double
(Closed)
Created 12 years, 10 months ago by guanqun
Modified 12 years, 9 months ago
Reviewers: reed1
Base URL: http://skia.googlecode.com/svn/trunk
Comments: 0