Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(619)

Issue 5645064: add explicit cast from SkScalar to double (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by guanqun
Modified:
12 years, 1 month ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

add explicit cast from SkScalar to double Otherwise the error could happen when SkScalar is SkFixed. BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M samplecode/SamplePath.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/svg/SkSVGCircle.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/svg/SkSVGEllipse.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
guanqun
Please review. Thanks! BTW: In some skia code, I've seen the assumption that SkScalar is ...
12 years, 1 month ago (2012-02-09 06:55:01 UTC) #1
reed1
lgtm We still support a compile-time flag that makes SkScalar==SkFixed. This is not exercised by ...
12 years, 1 month ago (2012-02-15 21:43:58 UTC) #2
guanqun
On 2012/02/15 21:43:58, reed1 wrote: > We still support a compile-time flag that makes SkScalar==SkFixed. ...
12 years, 1 month ago (2012-02-16 05:58:20 UTC) #3
reed1
12 years, 1 month ago (2012-02-16 13:20:29 UTC) #4
landed in rev. 3206
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b