Issue 5645058: code review 5645058: spec: add forward links from 'method set' to where it g...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5645058: code review 5645058: spec: add forward links from 'method set' to where it g... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

spec: add forward links from 'method set' to where it gets used Fixes issue 1797.

Patch Set 2 : diff -r 13cd383941ad https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d739d7e8b0e6 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d739d7e8b0e6 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 5 : diff -r d739d7e8b0e6 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	doc/go_spec.html	View	1 2 3 4	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2012-02-08 18:51:03 UTC) #1

rsc

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 4 months ago (2012-02-08 18:51:18 UTC) #2

gri

LGTM http://codereview.appspot.com/5645058/diff/6001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5645058/diff/6001/doc/go_spec.html#newcode3 doc/go_spec.html:3: "Subtitle": "Version of February 6, 2012" s/6/8/ http://codereview.appspot.com/5645058/diff/6001/doc/go_spec.html#newcode660 ...

13 years, 4 months ago (2012-02-08 18:57:25 UTC) #3

rsc

http://codereview.appspot.com/5645058/diff/6001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/5645058/diff/6001/doc/go_spec.html#newcode660 doc/go_spec.html:660: consists of all methods with receiver type <code>T</code>. On ...

13 years, 4 months ago (2012-02-08 19:27:10 UTC) #4

rsc

13 years, 4 months ago (2012-02-08 19:28:55 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=93f55b15c3af ***

spec: add forward links from 'method set' to where it gets used

Fixes issue 1797.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5645058

Expand All Messages | Collapse All Messages