Issue 5645050: code review 5645050: encoding/xml: add support for the omitempty flag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5645050: code review 5645050: encoding/xml: add support for the omitempty flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by niemeyer

Modified:
12 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

encoding/xml: add support for the omitempty flag This also changes the behavior of attribute marshalling so that strings and byte slices are marshalled even if empty. The omitempty flag may be used to obtain the previous behavior. Fixes issue 2899.

Patch Set 1 #

Patch Set 2 : code review 5645050: encoding/xml: support omitempty flag #

Patch Set 3 : code review 5645050: encoding/xml: add support for the omitempty flag #

Patch Set 4 : diff -r 320932bfe991 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 320932bfe991 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 1d946b0cc3fe https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -19 lines)			Patch
M	src/pkg/encoding/xml/marshal.go	View	1 2 3 4	6 chunks	+30 lines, -6 lines	0 comments	Download
M	src/pkg/encoding/xml/marshal_test.go	View	1 2 3	3 chunks	+80 lines, -6 lines	0 comments	Download
M	src/pkg/encoding/xml/read_test.go	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/encoding/xml/typeinfo.go	View	1 2 3	2 chunks	+12 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-08 03:13:17 UTC) #1

niemeyer

12 years, 2 months ago (2012-02-08 03:57:51 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=108147cd1f5b ***

encoding/xml: add support for the omitempty flag

This also changes the behavior of attribute marshalling so
that strings and byte slices are marshalled even if empty.
The omitempty flag may be used to obtain the previous behavior.

Fixes issue 2899.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5645050

Expand All Messages | Collapse All Messages