Issue 5644064: code review 5644064: gc: implicit type bug fix in export data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5644064: code review 5644064: gc: implicit type bug fix in export data (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
lvd, golang-dev

Visibility:
Public.

Description

gc: implicit type bug fix in export data

Patch Set 1 #

Patch Set 2 : diff -r 1f2a839158ce https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a90ca1755aa5 https://go.googlecode.com/hg #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+761 lines, -203 lines)			Patch
M	src/cmd/gc/fmt.c	View	1	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	2 chunks	+1 line, -8 lines	0 comments	Download
M	src/cmd/gc/go.y	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/cmd/gc/y.tab.h	View	1	3 chunks	+25 lines, -19 lines	0 comments	Download
M	src/cmd/gc/y.tab.c	View	1	296 chunks	+703 lines, -166 lines	0 comments	Download
M	test/fixedbugs/bug392.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/fixedbugs/bug392.dir/one.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
A	test/fixedbugs/bug392.dir/three.go	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	test/fixedbugs/bug392.dir/two.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello lvd (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 4 months ago (2012-02-09 05:26:06 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=2103d0f5c2b9 *** gc: implicit type bug fix in export data TBR=lvd CC=golang-dev ...

13 years, 4 months ago (2012-02-09 05:26:12 UTC) #2

lvd

13 years, 4 months ago (2012-02-09 06:55:53 UTC) #3

LGTM

how annoying.

On Thu, Feb 9, 2012 at 06:26,  <rsc@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=2103d0f5c2b9 ***
>
>
> gc: implicit type bug fix in export data
>
> TBR=lvd
> CC=golang-dev
> http://codereview.appspot.com/5644064
>
>
> http://codereview.appspot.com/5644064/

Expand All Messages | Collapse All Messages