Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(571)

Issue 5644049: code review 5644049: net/http: don't ignore some errors in tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by bradfitz
Modified:
12 years, 1 month ago
Reviewers:
CC:
golang-dev, dsymonds
Visibility:
Public.

Description

net/http: don't ignore some errors in tests to help debug Issue 2651

Patch Set 1 #

Patch Set 2 : diff -r 73a4a2506d41 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 73a4a2506d41 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8d1bf9e0a230 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/pkg/net/http/transport_test.go View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2012-02-08 02:47:22 UTC) #1
dsymonds
LGTM
12 years, 1 month ago (2012-02-08 03:14:32 UTC) #2
bradfitz
12 years, 1 month ago (2012-02-08 03:15:32 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=55a2b99f7a3b ***

net/http: don't ignore some errors in tests

to help debug Issue 2651

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/5644049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b