code review 5643068: os: clarify docs for link functions

os: clarify docs for link functions

[niemeyer, 2012-02-09 03:36:57]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bsiegert, 2012-02-09 09:40:53]

LGTM

[r, 2012-02-09 11:25:15]

http://codereview.appspot.com/5643068/diff/2002/src/pkg/os/file_posix.go
File src/pkg/os/file_posix.go (right):

http://codereview.appspot.com/5643068/diff/2002/src/pkg/os/file_posix.go#newc...
src/pkg/os/file_posix.go:41: // Link returns an error if newname already exists.
i think this is needless detail. things get errors for a variety of reasons.
what matters is that this is a LinkError, but that's not true for all operating
systems, unlike with the PathError changes, and this is a minor case anyway, and
the information you need is on LinkError itself.

PathError is the one that matters.

i like your first sentence but say, drop the second. same below.

[niemeyer, 2012-02-09 21:23:55]

Hello golang-dev@googlegroups.com, bsiegert@gmail.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-02-12 20:45:08]

LGTM

[niemeyer, 2012-02-13 03:21:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=8296cf56b8c1 ***

os: clarify docs for link functions

R=golang-dev, bsiegert, r
CC=golang-dev
http://codereview.appspot.com/5643068