code review 5643058: encoding/json: document buffering

encoding/json: document buffering

Fixes issue 1955.

[rsc, 2012-02-08 15:23:09]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[gri, 2012-02-08 17:08:40]

What about not reading too much if the reader is a ByteReader instead?
- gri

On Wed, Feb 8, 2012 at 7:23 AM,  <rsc@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> encoding/json: document buffering
>
> Fixes issue 1955.
>
> Please review this at http://codereview.appspot.com/5643058/
>
> Affected files:
>  M src/pkg/encoding/json/stream.go
>
>
> Index: src/pkg/encoding/json/stream.go
> ===================================================================
> --- a/src/pkg/encoding/json/stream.go
> +++ b/src/pkg/encoding/json/stream.go
> @@ -19,6 +19,9 @@
>  }
>
>  // NewDecoder returns a new decoder that reads from r.
> +//
> +// The decoder introduces its own buffering and may
> +// read data from r beyond the JSON values requested.
>  func NewDecoder(r io.Reader) *Decoder {
>        return &Decoder{r: r}
>  }
>
>

[gri, 2012-02-08 17:09:23]

Never mind. Just seen the other mail.
LGTM.
- gri

On Wed, Feb 8, 2012 at 9:08 AM, Robert Griesemer <gri@golang.org> wrote:
> What about not reading too much if the reader is a ByteReader instead?
> - gri
>
> On Wed, Feb 8, 2012 at 7:23 AM,  <rsc@golang.org> wrote:
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://code.google.com/p/go/
>>
>>
>> Description:
>> encoding/json: document buffering
>>
>> Fixes issue 1955.
>>
>> Please review this at http://codereview.appspot.com/5643058/
>>
>> Affected files:
>>  M src/pkg/encoding/json/stream.go
>>
>>
>> Index: src/pkg/encoding/json/stream.go
>> ===================================================================
>> --- a/src/pkg/encoding/json/stream.go
>> +++ b/src/pkg/encoding/json/stream.go
>> @@ -19,6 +19,9 @@
>>  }
>>
>>  // NewDecoder returns a new decoder that reads from r.
>> +//
>> +// The decoder introduces its own buffering and may
>> +// read data from r beyond the JSON values requested.
>>  func NewDecoder(r io.Reader) *Decoder {
>>        return &Decoder{r: r}
>>  }
>>
>>

[rsc, 2012-02-08 18:48:06]

*** Submitted as http://code.google.com/p/go/source/detail?r=8969fb908048 ***

encoding/json: document buffering

Fixes issue 1955.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5643058