Issue 5643054: code review 5643054: runtime/cgo: silence warning on windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5643054: code review 5643054: runtime/cgo: silence warning on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by r

Modified:
12 years, 2 months ago

Reviewers:
iant2

CC:
golang-dev

Visibility:
Public.

Description

runtime/cgo: silence warning on windows It appears to want a * on an indirect function call (assembly language) TBR=rsc

Patch Set 1 #

Patch Set 2 : diff -r 490c5562b380 https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/cgo/gcc_amd64.S	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-08 04:26:08 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=c5594074a09a *** runtime/cgo: silence warning on windows It appears to want a ...

12 years, 2 months ago (2012-02-08 04:26:43 UTC) #2

iant2

12 years, 2 months ago (2012-02-08 05:13:08 UTC) #3

LGTM

r@golang.org writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> runtime/cgo: silence warning on windows
> It appears to want a * on an indirect function call (assembly language)
>
> Please review this at http://codereview.appspot.com/5643054/
>
> Affected files:
>   M src/pkg/runtime/cgo/gcc_amd64.S
>
>
> Index: src/pkg/runtime/cgo/gcc_amd64.S
> ===================================================================
> --- a/src/pkg/runtime/cgo/gcc_amd64.S
> +++ b/src/pkg/runtime/cgo/gcc_amd64.S
> @@ -70,7 +70,7 @@
>  	movq  %rdx, 0(%rsp)	/* arg */
>  	movq  %r8, 8(%rsp)	/* argsize (includes padding) */
>  	
> -	call %rcx	/* fn */
> +	call *%rcx	/* fn */
>  #else
>  	movq  %rsi, 0(%rsp)	/* arg */
>  	movq  %rdx, 8(%rsp)	/* argsize (includes padding) */

Expand All Messages | Collapse All Messages