code review 5642065: bytes.Buffer: return error in WriteTo if buffer is not ...

bytes.Buffer: return error in WriteTo if buffer is not drained

[r, 2012-02-08 21:43:12]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-02-08 21:46:54]

http://codereview.appspot.com/5642065/diff/1/src/pkg/bytes/buffer.go
File src/pkg/bytes/buffer.go (right):

http://codereview.appspot.com/5642065/diff/1/src/pkg/bytes/buffer.go#newcode40
src/pkg/bytes/buffer.go:40: var ErrShortWrite = errors.New("bytes.Buffer:
WriteTo did not drain buffer")
Use io.ErrShortWrite instead?

[r, 2012-02-08 21:54:43]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r2, 2012-02-08 21:55:09]

On 09/02/2012, at 8:46 AM, rsc@golang.org wrote:

> 
> http://codereview.appspot.com/5642065/diff/1/src/pkg/bytes/buffer.go
> File src/pkg/bytes/buffer.go (right):
> 
> http://codereview.appspot.com/5642065/diff/1/src/pkg/bytes/buffer.go#newcode40
> src/pkg/bytes/buffer.go:40: var ErrShortWrite =
> errors.New("bytes.Buffer: WriteTo did not drain buffer")
> Use io.ErrShortWrite instead?

sure. forgot we already imported io.

-rob

[rsc, 2012-02-08 21:57:14]

LGTM

[r, 2012-02-08 21:58:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=a382ad8ae575 ***

bytes.Buffer: return error in WriteTo if buffer is not drained

R=rsc
CC=golang-dev
http://codereview.appspot.com/5642065