code review 5642054: bufio: drop error return for NewReaderSize and NewWriterSize

bufio: drop error return for NewReaderSize and NewWriterSize
It complicates the interface unnecessarily.
Document this in go1.html.
Also update the go/doc Makefile.

Fixes issue 2836.

[r, 2012-02-08 00:39:36]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2012-02-08 01:20:38]

http://codereview.appspot.com/5642054/diff/18/src/pkg/bufio/bufio.go
File src/pkg/bufio/bufio.go (right):

http://codereview.appspot.com/5642054/diff/18/src/pkg/bufio/bufio.go#newcode44
src/pkg/bufio/bufio.go:44: // size. If the argument io.Reader is already a
Reader with large enough
If the argument rd is already an io.Reader, it is returned unchanged.

(it cannot have a smaller size anymore, after all)

http://codereview.appspot.com/5642054/diff/18/src/pkg/bufio/bufio.go#newcode45
src/pkg/bufio/bufio.go:45: // size, it returns the underlying Reader. It returns
the Reader and any  error.
leave away the last sentence - for one there's no error anymore, the rest is
obvious

http://codereview.appspot.com/5642054/diff/18/src/pkg/bufio/bufio.go#newcode52
src/pkg/bufio/bufio.go:52: if ok && len(b.buf) >= size {
the buf size check is not needed anymore, isn't it?

http://codereview.appspot.com/5642054/diff/18/src/pkg/bufio/bufio.go#newcode385
src/pkg/bufio/bufio.go:385: // NewWriterSize creates a new Writer whose buffer
has at least the specified
adjust comment as above

http://codereview.appspot.com/5642054/diff/18/src/pkg/bufio/bufio.go#newcode394
src/pkg/bufio/bufio.go:394: if ok && len(b.buf) >= size {
size check may not be needed anymore

[r, 2012-02-08 01:47:47]

Hello golang-dev@googlegroups.com, gri@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-02-08 01:48:43]

http://codereview.appspot.com/5642054/diff/18/src/pkg/bufio/bufio.go
File src/pkg/bufio/bufio.go (right):

http://codereview.appspot.com/5642054/diff/18/src/pkg/bufio/bufio.go#newcode44
src/pkg/bufio/bufio.go:44: // size. If the argument io.Reader is already a
Reader with large enough
yes it can. i rearranged the code a bit to be closer to the proper intent, but
regardless the size check remains because the existing buffer must be big
enough.

[bradfitz, 2012-02-08 01:54:39]

LGTM

http://codereview.appspot.com/5642054/diff/2003/src/pkg/bufio/bufio.go
File src/pkg/bufio/bufio.go (right):

http://codereview.appspot.com/5642054/diff/2003/src/pkg/bufio/bufio.go#newcode60
src/pkg/bufio/bufio.go:60: return b
now that it's just returning a single value, it could be a composite literal:

return &Reader{
   buf: make([]byte, size),
   rd: rd,
   lastByte: -1,
   lastRuneSize: -1,
}

[r, 2012-02-08 02:07:20]

*** Submitted as http://code.google.com/p/go/source/detail?r=062ed4b8b8de ***

bufio: drop error return for NewReaderSize and NewWriterSize
It complicates the interface unnecessarily.
Document this in go1.html.
Also update the go/doc Makefile.

Fixes issue 2836.

R=golang-dev, gri, bradfitz
CC=golang-dev
http://codereview.appspot.com/5642054

[rsc, 2012-02-08 03:39:39]

LGTM

Thanks.