Issue 5641052: code review 5641052: cmd/go: connect os.Stdin for go run

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5641052: code review 5641052: cmd/go: connect os.Stdin for go run (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by bradfitz

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, r, rsc

Visibility:
Public.

Description

cmd/go: connect os.Stdin for go run Fixes issue 2875

Patch Set 2 : diff -r 1c0ec7c9634b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1c0ec7c9634b https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 001b807ba435 https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	src/cmd/go/run.go	View	1 2 3	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2012-02-08 05:20:30 UTC) #1

LGTM although i'm nervous about EPIPE http://codereview.appspot.com/5641052/diff/3001/src/cmd/go/run.go File src/cmd/go/run.go (right): http://codereview.appspot.com/5641052/diff/3001/src/cmd/go/run.go#newcode76 src/cmd/go/run.go:76: cmd.Stdin = os.Stdin ...

12 years, 2 months ago (2012-02-08 05:22:12 UTC) #2

rsc

If we could use os.Exec here, I would suggest that. But it doesn't work on ...

12 years, 2 months ago (2012-02-08 05:23:28 UTC) #4

bradfitz

12 years, 2 months ago (2012-02-08 05:30:34 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=78f5b01366f2 ***

cmd/go: connect os.Stdin for go run

Fixes issue 2875

R=golang-dev, r, rsc
CC=golang-dev
http://codereview.appspot.com/5641052

Expand All Messages | Collapse All Messages