code review 5641050: encoding/csv: document ReadAll behavior at EOF

encoding/csv: document ReadAll behavior at EOF

Fixes issue 2847.

[r, 2012-02-08 03:11:57]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-02-08 03:12:53]

LGTM

On Tue, Feb 7, 2012 at 7:11 PM, <r@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> encoding/csv: document ReadAll behavior at EOF
>
> Fixes issue 2847.
>
> Please review this at
http://codereview.appspot.com/**5641050/<http://codereview.appspot.com/5641050/>
>
> Affected files:
>  M src/pkg/encoding/csv/reader.go
>
>
> Index: src/pkg/encoding/csv/reader.go
> ==============================**==============================**=======
> --- a/src/pkg/encoding/csv/reader.**go
> +++ b/src/pkg/encoding/csv/reader.**go
> @@ -156,6 +156,9 @@
>
>  // ReadAll reads all the remaining records from r.
>  // Each record is a slice of fields.
> +// A successful call returns err == nil, not err == EOF. Because ReadAll
> is
> +// defined to read until EOF, it does not treat end of file as an error
> to be
> +// reported.
>  func (r *Reader) ReadAll() (records [][]string, err error) {
>        for {
>                record, err := r.Read()
>
>
>

[r, 2012-02-08 03:24:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=37a5f3ad9990 ***

encoding/csv: document ReadAll behavior at EOF

Fixes issue 2847.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5641050