code review 5639064: misc/dist: add binary distribution packaging script for...

misc/dist: add binary distribution packaging script for linux

[adg, 2012-02-09 00:23:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[bradfitzgoog, 2012-02-09 00:28:47]

LGTM

I'd kinda prefer that this be written in Go, but shell works too.

See one comment below.

http://codereview.appspot.com/5639064/diff/1/misc/dist/linux/dist.bash
File misc/dist/linux/dist.bash (right):

http://codereview.appspot.com/5639064/diff/1/misc/dist/linux/dist.bash#newcode54
misc/dist/linux/dist.bash:54: tar czf $DEST go
I'd at least prefer when untarring this to have the directory be:

go.VERSION.GOOS-GOARCH rather than "go"

[iant, 2012-02-09 01:23:27]

http://codereview.appspot.com/5639064/diff/1/misc/dist/linux/dist.bash
File misc/dist/linux/dist.bash (right):

http://codereview.appspot.com/5639064/diff/1/misc/dist/linux/dist.bash#newcode53
misc/dist/linux/dist.bash:53: echo "Writing tarball: $ROOT/$DEST"
There should be a README or INSTALL file in here somewhere.

[adg, 2012-02-09 02:48:59]

On 9 February 2012 12:23,  <iant@golang.org> wrote:
>
> http://codereview.appspot.com/5639064/diff/1/misc/dist/linux/dist.bash
> File misc/dist/linux/dist.bash (right):
>
>
http://codereview.appspot.com/5639064/diff/1/misc/dist/linux/dist.bash#newcode53
> misc/dist/linux/dist.bash:53: echo "Writing tarball: $ROOT/$DEST"
> There should be a README or INSTALL file in here somewhere.

There's a README in GOROOT that covers binary distros already.

[adg, 2012-02-09 02:49:12]

http://codereview.appspot.com/5639064/diff/1/misc/dist/linux/dist.bash
File misc/dist/linux/dist.bash (right):

http://codereview.appspot.com/5639064/diff/1/misc/dist/linux/dist.bash#newcode54
misc/dist/linux/dist.bash:54: tar czf $DEST go
On 2012/02/09 00:28:47, bradfitzgoog wrote:
> I'd at least prefer when untarring this to have the directory be:
> 
> go.VERSION.GOOS-GOARCH rather than "go"

I'd prefer people to be able to untar inside /usr/local and get /usr/local/go

[adg, 2012-02-13 10:18:24]

*** Submitted as http://code.google.com/p/go/source/detail?r=6fa9a06da071 ***

misc/dist: add binary distribution packaging script for linux

R=golang-dev, bradfitz, iant
CC=golang-dev
http://codereview.appspot.com/5639064