Issue 5639063: code review 5639063: misc/package: new hierarchy for package generation scripts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5639063: code review 5639063: misc/package: new hierarchy for package generation scripts (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by adg

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc, bradfitz

Visibility:
Public.

Description

misc/dist: new hierarchy for binary distribution packaging scripts

Patch Set 1 #

Patch Set 2 : diff -r 75b8bf14a037 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 75b8bf14a037 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 75b8bf14a037 https://go.googlecode.com/hg #

Patch Set 5 : diff -r 75b8bf14a037 https://go.googlecode.com/hg #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
A	misc/dist/README	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	misc/dist/darwin/README	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	misc/dist/darwin/dist.bash	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	misc/dist/darwin/etc/paths.d/go	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	misc/dist/darwin/scripts/postinstall	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

13 years, 4 months ago (2012-02-08 23:03:18 UTC) #1

adg

On 2012/02/08 23:09:20, rsc wrote: > Package has other meanings in Go. > dist? SGTM. ...

13 years, 4 months ago (2012-02-08 23:17:04 UTC) #3

adg

13 years, 4 months ago (2012-02-09 00:15:22 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=cfb4745513a9 ***

misc/dist: new hierarchy for binary distribution packaging scripts

R=golang-dev, rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/5639063

Expand All Messages | Collapse All Messages