Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(136)

Issue 5639062: code review 5639062: regexp: fix typo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by rsc
Modified:
13 years, 4 months ago
Reviewers:
iant2
CC:
golang-dev
Visibility:
Public.

Description

regexp: fix typo Fixes issue 2918.

Patch Set 1 #

Patch Set 2 : diff -r 0eab3b57c894 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0eab3b57c894 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/regexp/regexp.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years, 4 months ago (2012-02-08 13:59:57 UTC) #1
rsc
*** Submitted as de954bd3fabe *** regexp: fix typo Fixes issue 2918. TBR=golang-dev CC=golang-dev http://codereview.appspot.com/5639062
13 years, 4 months ago (2012-02-08 14:00:03 UTC) #2
iant2
13 years, 4 months ago (2012-02-08 14:38:36 UTC) #3
LGTM

rsc@golang.org writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> regexp: fix typo
>
> Fixes issue 2918.
>
> Please review this at http://codereview.appspot.com/5639062/
>
> Affected files:
>   M src/pkg/regexp/regexp.go
>
>
> Index: src/pkg/regexp/regexp.go
> ===================================================================
> --- a/src/pkg/regexp/regexp.go
> +++ b/src/pkg/regexp/regexp.go
> @@ -738,7 +738,7 @@
>
>  // ExpandString is like Expand but the template and source are strings.
>  // It appends to and returns a byte slice in order to give the calling
> -// code control ovr allocation.
> +// code control over allocation.
>  func (re *Regexp) ExpandString(dst []byte, template string, src
> string, match []int) []byte {
>  	return re.expand(dst, template, nil, src, match)
>  }
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b