Issue 5639053: code review 5639053: gofmt: replace defunct test.sh with a go test

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5639053: code review 5639053: gofmt: replace defunct test.sh with a go test (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by gri

Modified:
13 years, 4 months ago

Reviewers:

CC:
r, rsc1, golang-dev

Visibility:
Public.

Description

gofmt: replace defunct test.sh with a go test

Patch Set 2 : diff -r 0ff7fac59df1 https://code.google.com/p/go #

Total comments: 3

Patch Set 3 : diff -r 582fb3f6b4ce https://code.google.com/p/go #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -168 lines)			Patch
	A	src/cmd/gofmt/long_test.go	View	1 2	1 chunk	+157 lines, -0 lines	0 comments	Download
	R	src/cmd/gofmt/test.sh	View		1 chunk	+0 lines, -168 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

13 years, 4 months ago (2012-02-08 00:56:30 UTC) #1

rsc1

LGTM Nice. http://codereview.appspot.com/5639053/diff/4/src/cmd/gofmt/long_test.go File src/cmd/gofmt/long_test.go (right): http://codereview.appspot.com/5639053/diff/4/src/cmd/gofmt/long_test.go#newcode84 src/cmd/gofmt/long_test.go:84: // the first and 2nd result should ...

13 years, 4 months ago (2012-02-08 03:36:36 UTC) #2

gri

13 years, 4 months ago (2012-02-08 16:47:05 UTC) #3

*** Submitted as 2f11c30b6ba6 ***

gofmt: replace defunct test.sh with a go test

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/5639053

Expand All Messages | Collapse All Messages