Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(481)

Issue 5639052: code review 5639052: strconv: handle very large inputs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by rsc
Modified:
12 years, 1 month ago
Reviewers:
CC:
remyoudompheng, r, r2, golang-dev
Visibility:
Public.

Description

strconv: handle very large inputs Fixes issue 2642.

Patch Set 1 #

Patch Set 2 : diff -r 915676d75024 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r 73fbf2edae3d https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -16 lines) Patch
M src/pkg/strconv/atof.go View 1 2 chunks +7 lines, -3 lines 0 comments Download
M src/pkg/strconv/atof_test.go View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/pkg/strconv/decimal.go View 1 2 8 chunks +28 lines, -13 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello remyoudompheng (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 1 month ago (2012-02-07 23:15:41 UTC) #1
remyoudompheng
LGTM
12 years, 1 month ago (2012-02-07 23:29:28 UTC) #2
remyoudompheng
http://codereview.appspot.com/5639052/diff/1002/src/pkg/strconv/decimal.go File src/pkg/strconv/decimal.go (right): http://codereview.appspot.com/5639052/diff/1002/src/pkg/strconv/decimal.go#newcode314 src/pkg/strconv/decimal.go:314: // Returns receiver for convenience. I'm noticing this extra ...
12 years, 1 month ago (2012-02-07 23:30:57 UTC) #3
r
LGTM http://codereview.appspot.com/5639052/diff/1002/src/pkg/strconv/decimal.go File src/pkg/strconv/decimal.go (right): http://codereview.appspot.com/5639052/diff/1002/src/pkg/strconv/decimal.go#newcode15 src/pkg/strconv/decimal.go:15: d [800]byte // digits LGTM for now, but ...
12 years, 1 month ago (2012-02-07 23:36:05 UTC) #4
rsc
On Tue, Feb 7, 2012 at 18:36, <r@golang.org> wrote: > LGTM for now, but i ...
12 years, 1 month ago (2012-02-08 03:26:37 UTC) #5
r2
On Feb 8, 2012, at 2:26 PM, Russ Cox wrote: > On Tue, Feb 7, ...
12 years, 1 month ago (2012-02-08 03:31:42 UTC) #6
rsc
12 years, 1 month ago (2012-02-08 04:37:17 UTC) #7
*** Submitted as c111d33ea407 ***

strconv: handle very large inputs

Fixes issue 2642.

R=remyoudompheng, r, r
CC=golang-dev
http://codereview.appspot.com/5639052
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b