code review 5632043: goauth2: Convert buzz example to profile since buzz is ...

goauth2: Convert buzz example to profile since buzz is deprecated

[M-A, 2012-02-05 02:58:37]

~/...src/code.google.com/p/goauth2> hg st
M oauth/oauth.go
A oauth/example/profile.go
R oauth/example/buzz.go

hg change failed to upload the deleted buzz.go. If you commit this CL, please
make sure to delete buzz.go manually.

[adg, 2012-02-05 12:28:15]

There's already another CL that addresses this:

http://codereview.appspot.com/5632043/

I like your example code change, though.

[adg, 2012-02-05 13:01:11]

Please take a look at this: http://codereview.appspot.com/5629060/

[M-A, 2012-02-05 14:10:38]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/goauth2/

[M-A, 2012-02-05 14:11:24]

On 2012/02/05 14:10:38, M-A wrote:
> Hello mailto:adg@golang.org (cc: mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/goauth2/

(Sorry I didn't find the command to upload without emailing)

Removed oauth.go, just kept the example change.

[M-A, 2012-02-05 14:16:04]

On 2012/02/05 14:11:24, M-A wrote:
> (Sorry I didn't find the command to upload without emailing)

Ugh, found.

[dupoxy, 2012-02-05 14:16:56]

somone on this list called minux once told me:
" You can use 'hg upload 9999' to upload a new revision of CL"

[adg, 2012-02-05 23:42:56]

Hey, have you signed the CLA?

http://golang.org/doc/contribute.html#copyright

[adg, 2012-08-08 00:48:33]

Ping?

[r, 2012-08-08 03:08:26]

LGTM

[M-A, 2012-08-18 19:42:42]

On 2012/08/08 00:48:33, adg wrote:
> Ping?

FTR, I'm pretty sure I had communicated to you by IM that I am a Google employee
so I didn't need to sign the CLA but I can't find it in my gtalk history. Sorry
I should have replied here instead.

[adg, 2012-08-20 02:05:22]

I dimly recall that, but yeah, it's better to put it in the thread so
it's on record.

Anyway, it looks like Anthony Starks' recent changes have made this
one obsolete. Thanks anyway.

Andrew

On 19 August 2012 05:42,  <maruel@chromium.org> wrote:
> On 2012/08/08 00:48:33, adg wrote:
>>
>> Ping?
>
>
> FTR, I'm pretty sure I had communicated to you by IM that I am a Google
> employee so I didn't need to sign the CLA but I can't find it in my
> gtalk history. Sorry I should have replied here instead.
>
> http://codereview.appspot.com/5632043/