Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(653)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5629051: code review 5629051: cmd/dist: more build fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by rsc
Modified:
13 years, 5 months ago
Reviewers:
mikio
CC:
golang-dev
Visibility:
Public.

Description

cmd/dist: more build fixes Flush stdout before writing to stderr, to avoid reordering output. Allow amd64 from uname -m (FreeBSD).

Patch Set 1 #

Patch Set 2 : diff -r 5988d951acab https://code.google.com/p/go/ #

Patch Set 3 : diff -r 5988d951acab https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/cmd/dist/unix.c View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years, 5 months ago (2012-02-04 06:46:45 UTC) #1
rsc
*** Submitted as 830d67171f60 *** cmd/dist: more build fixes Flush stdout before writing to stderr, ...
13 years, 5 months ago (2012-02-04 06:46:48 UTC) #2
mikio
13 years, 5 months ago (2012-02-04 09:05:00 UTC) #3 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b