Issue 5629046: code review 5629046: freetype: delete Makefiles.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5629046: code review 5629046: freetype: delete Makefiles. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by nigeltao

Modified:
12 years, 9 months ago

Reviewers:

CC:
rsc, dave_cheney.net, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r c9c9c863abe0 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r c9c9c863abe0 https://code.google.com/p/freetype-go #

Total comments: 1

Patch Set 4 : diff -r c9c9c863abe0 https://code.google.com/p/freetype-go #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -64 lines)			Patch
R	Makefile	View	1	1 chunk	+0 lines, -23 lines	0 comments	Download
M	README	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
R	freetype/Makefile	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
R	freetype/raster/Makefile	View	1	1 chunk	+0 lines, -15 lines	0 comments	Download
R	freetype/truetype/Makefile	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

12 years, 9 months ago (2012-02-03 22:12:38 UTC) #1

dave_cheney.net

http://codereview.appspot.com/5629046/diff/3001/README File README (right): http://codereview.appspot.com/5629046/diff/3001/README#newcode6 README:6: $ go install code.google.com/p/freetype-go/freetype You don't need the go ...

12 years, 9 months ago (2012-02-03 22:15:07 UTC) #2

nigeltao

12 years, 9 months ago (2012-02-03 22:32:13 UTC) #4

*** Submitted as fdad42c15bb1 ***

freetype: delete Makefiles.

R=rsc, dave
CC=golang-dev
http://codereview.appspot.com/5629046

Expand All Messages | Collapse All Messages