Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 5627043: code review 5627043: lib9/utf: make safe for automatic build (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by rsc
Modified:
13 years, 5 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

lib9/utf: make safe for automatic build Add // +build ignore to mkrunetype.c, rename runetypebody to be .h since it is #included, delete old runetypebody tables.

Patch Set 1 #

Patch Set 2 : diff -r 6bb5429f822c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6bb5429f822c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4d519971228f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2902 lines) Patch
M src/lib9/utf/mkrunetype.c View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/lib9/utf/runetype.c View 1 1 chunk +1 line, -1 line 0 comments Download
R src/lib9/utf/runetypebody-5.0.0.c View 1 1 chunk +0 lines, -1361 lines 0 comments Download
R src/lib9/utf/runetypebody-5.2.0.c View 1 1 chunk +0 lines, -1541 lines 0 comments Download
M src/lib9/utf/runetypebody-6.0.0.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2012-02-03 18:24:33 UTC) #1
bradfitz
LGTM On Fri, Feb 3, 2012 at 10:24 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 5 months ago (2012-02-03 18:27:25 UTC) #2
rsc
13 years, 5 months ago (2012-02-03 20:19:03 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=637521b3a64f ***

lib9/utf: make safe for automatic build

Add // +build ignore to mkrunetype.c,
rename runetypebody to be .h since it is #included,
delete old runetypebody tables.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5627043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b