Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2042)

Issue 5624055: page-layout: loose lines between systems; issue 2276 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Keith
Modified:
12 years, 3 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

page-layout: loose lines between systems; issue 2276 Ensure enough space between systems that the baselines of loose lines on a lower system, can always lie below baselines of loose lines on the system above.

Patch Set 1 #

Patch Set 2 : tweak regtest for issue 496 #

Total comments: 1

Patch Set 3 : avoid interaction with issue 496 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M input/regression/page-spacing-nonstaff-lines-between-systems.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/page-layout-problem.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/page-layout-problem.cc View 1 2 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Keith
http://codereview.appspot.com/5624055/diff/2001/lily/page-layout-problem.cc File lily/page-layout-problem.cc (right): http://codereview.appspot.com/5624055/diff/2001/lily/page-layout-problem.cc#newcode607 lily/page-layout-problem.cc:607: Real min_distance = bottom_loose_baseline_ - minimum_offsets_with_min_dist[i]; The springs being ...
12 years, 3 months ago (2012-02-05 07:56:21 UTC) #1
Keith
12 years, 3 months ago (2012-02-05 23:18:33 UTC) #2
On 2012/02/05 07:56:21, Keith wrote:
> This would probably work better as [ ... ] 
> so that it excludes protrusions above the first staff in a system, 
> such as high notes.  

Better to limit the action of this patch to situations when a loose line lies
above the first staff in a system.  We probably never want contents of Lyrics or
Chordnames to interleave with the system above.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b