code review 5624048: archive/zip: support full range of FileMode flags

archive/zip: support full range of FileMode flags

Zip files may actually store symlinks, and that's represented
as a file with unix flag S_IFLNK and with its data containing
the symlink target name.

The other flags are being supported too. Now that the os package
has the full range of flags in a system agnostic manner, there's
no reason to discard that information.

[niemeyer, 2012-02-04 00:11:42]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2012-02-05 23:58:26]

LGTM

http://codereview.appspot.com/5624048/diff/3/src/pkg/archive/zip/struct.go
File src/pkg/archive/zip/struct.go (right):

http://codereview.appspot.com/5624048/diff/3/src/pkg/archive/zip/struct.go#ne...
src/pkg/archive/zip/struct.go:157: // but these seem to be the values agreed on
by tools.
Is there some reference you can cite here? I hate the cargo cultyness of the zip
format. :-/

[niemeyer, 2012-02-06 01:06:35]

http://codereview.appspot.com/5624048/diff/3/src/pkg/archive/zip/struct.go
File src/pkg/archive/zip/struct.go (right):

http://codereview.appspot.com/5624048/diff/3/src/pkg/archive/zip/struct.go#ne...
src/pkg/archive/zip/struct.go:157: // but these seem to be the values agreed on
by tools.
On 2012/02/05 23:58:26, adg wrote:
> Is there some reference you can cite here? I hate the cargo cultyness of the
zip
> format. :-/

That specific detail is explicitly stated as being system dependent in the
specification, which of course makes no sense for a portable file format. As a
result, there is no authoritative reference, but we can certainly find people
lamenting about it.

Hopefully that won't be a problem in practice given that tools seem to agree on
those values.

[rog, 2012-02-06 11:20:46]

LGTM

On 6 February 2012 01:06,  <n13m3y3r@gmail.com> wrote:
>
> http://codereview.appspot.com/5624048/diff/3/src/pkg/archive/zip/struct.go
> File src/pkg/archive/zip/struct.go (right):
>
>
http://codereview.appspot.com/5624048/diff/3/src/pkg/archive/zip/struct.go#ne...
> src/pkg/archive/zip/struct.go:157: // but these seem to be the values
> agreed on by tools.
> On 2012/02/05 23:58:26, adg wrote:
>>
>> Is there some reference you can cite here? I hate the cargo cultyness
>
> of the zip
>>
>> format. :-/
>
>
> That specific detail is explicitly stated as being system dependent in
> the specification, which of course makes no sense for a portable file
> format. As a result, there is no authoritative reference, but we can
> certainly find people lamenting about it.
>
> Hopefully that won't be a problem in practice given that tools seem to
> agree on those values.
>
> http://codereview.appspot.com/5624048/

[niemeyer, 2012-02-06 13:59:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=42021369841c ***

archive/zip: support full range of FileMode flags

Zip files may actually store symlinks, and that's represented
as a file with unix flag S_IFLNK and with its data containing
the symlink target name.

The other flags are being supported too. Now that the os package
has the full range of flags in a system agnostic manner, there's
no reason to discard that information.

R=golang-dev, adg, rogpeppe
CC=golang-dev
http://codereview.appspot.com/5624048