Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 5622050: code review 5622050: 5a, 6a, 8a, cc: check in y.tab.[ch] (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by rsc
Modified:
13 years, 7 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

5a, 6a, 8a, cc: check in y.tab.[ch] This enables builds on systems without Bison/yacc.

Patch Set 1 #

Patch Set 2 : diff -r b5548669fc39 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b5548669fc39 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b5548669fc39 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r fe60484996da https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13006 lines, -2 lines) Patch
M src/Make.ctool View 1 1 chunk +0 lines, -2 lines 0 comments Download
A src/cmd/5a/y.tab.h View 1 1 chunk +166 lines, -0 lines 0 comments Download
A src/cmd/5a/y.tab.c View 1 1 chunk +2949 lines, -0 lines 0 comments Download
A src/cmd/6a/y.tab.h View 1 1 chunk +135 lines, -0 lines 0 comments Download
A src/cmd/6a/y.tab.c View 1 1 chunk +2730 lines, -0 lines 0 comments Download
A src/cmd/8a/y.tab.h View 1 1 chunk +135 lines, -0 lines 0 comments Download
A src/cmd/8a/y.tab.c View 1 1 chunk +2852 lines, -0 lines 0 comments Download
A src/cmd/cc/y.tab.h View 1 1 chunk +228 lines, -0 lines 0 comments Download
A src/cmd/cc/y.tab.c View 1 1 chunk +3811 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 7 months ago (2012-02-03 04:38:21 UTC) #1
bradfitz
LGTM On Thu, Feb 2, 2012 at 8:38 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 7 months ago (2012-02-03 08:46:11 UTC) #2
rsc
13 years, 7 months ago (2012-02-03 15:53:56 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=d3b2bc8b27d9 ***

5a, 6a, 8a, cc: check in y.tab.[ch]

This enables builds on systems without Bison/yacc.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5622050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b