Issue 5622043: code review 5622043: codereview: don't check default paths when codereview d...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5622043: code review 5622043: codereview: don't check default paths when codereview d... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by adg

Modified:
13 years, 4 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

codereview: don't check default paths when codereview disabled

Patch Set 1 #

Total comments: 1

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	lib/codereview/codereview.py	View		2 chunks	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 5 months ago (2012-02-02 03:03:04 UTC) #1

rsc

http://codereview.appspot.com/5622043/diff/1/lib/codereview/codereview.py File lib/codereview/codereview.py (right): http://codereview.appspot.com/5622043/diff/1/lib/codereview/codereview.py#newcode2222 lib/codereview/codereview.py:2222: Please move the lines all the way down here. ...

13 years, 5 months ago (2012-02-02 17:29:41 UTC) #2

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=7b05b761af6c *** codereview: don't check default paths when codereview disabled R=golang-dev, rsc ...

13 years, 5 months ago (2012-02-02 19:25:16 UTC) #4

*** Abandoned ***

Expand All Messages | Collapse All Messages