Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(204)

Issue 5619045: code review 5619045: syscall: fix build directive in types_linux.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by rsc
Modified:
13 years, 5 months ago
Reviewers:
CC:
golang-dev, adg, bradfitz
Visibility:
Public.

Description

syscall: fix build directive in types_linux.go The rule is that build directives can be preceded only by blank lines and other line comments, not /* */ comments.

Patch Set 1 #

Patch Set 2 : diff -r f79343c8a479 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f79343c8a479 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 5588ff80d523 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/pkg/syscall/types_linux.go View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 5 months ago (2012-02-01 22:49:27 UTC) #1
adg
LGTM
13 years, 5 months ago (2012-02-01 23:00:43 UTC) #2
bradfitz
LGTM On Wed, Feb 1, 2012 at 2:49 PM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 5 months ago (2012-02-01 23:00:46 UTC) #3
rsc
13 years, 5 months ago (2012-02-01 23:25:54 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=1a7e26c156b8 ***

syscall: fix build directive in types_linux.go

The rule is that build directives can be preceded only
by blank lines and other line comments, not /* */ comments.

R=golang-dev, adg, bradfitz
CC=golang-dev
http://codereview.appspot.com/5619045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b