Make sure color is not used in git diff or hg diff

Make sure color is not used in git diff or hg diff

[Andi Albrecht, 2012-02-01 20:34:30]

LGTM

Out of curiosity, when do we have problems with colored output? I'm using
colored output for hg and git on my machines, but this causes no problems when
uploading patch sets.

http://codereview.appspot.com/5619043/diff/1/upload.py
File upload.py (right):

http://codereview.appspot.com/5619043/diff/1/upload.py#newcode1456
upload.py:1456: "hg", "diff", "--color", "never", "--git", "-r", self.base_rev
If --color is an issue with "hg", could the pager extension cause problems too?

[M-A, 2012-02-01 21:00:45]

On 2012/02/01 20:34:30, Andi Albrecht wrote:
> LGTM
> 
> Out of curiosity, when do we have problems with colored output? I'm using
> colored output for hg and git on my machines, but this causes no problems when
> uploading patch sets.

msysgit + cygwin breaks tty detection so some people use --color=always.

http://codereview.appspot.com/5619043/diff/1/upload.py
File upload.py (right):

http://codereview.appspot.com/5619043/diff/1/upload.py#newcode1456
upload.py:1456: "hg", "diff", "--color", "never", "--git", "-r", self.base_rev
On 2012/02/01 20:34:30, Andi Albrecht wrote:
> If --color is an issue with "hg", could the pager extension cause problems
too?

Right. I'll leave that for a follow up change.

[Andi Albrecht, 2012-02-06 10:47:24]

On 2012/02/01 21:00:45, M-A wrote:
> On 2012/02/01 20:34:30, Andi Albrecht wrote:
> > LGTM
> > 
> > Out of curiosity, when do we have problems with colored output? I'm using
> > colored output for hg and git on my machines, but this causes no problems
when
> > uploading patch sets.
> 
> msysgit + cygwin breaks tty detection so some people use --color=always.

ah, ok! Thanks!

> 
> http://codereview.appspot.com/5619043/diff/1/upload.py
> File upload.py (right):
> 
> http://codereview.appspot.com/5619043/diff/1/upload.py#newcode1456
> upload.py:1456: "hg", "diff", "--color", "never", "--git", "-r", self.base_rev
> On 2012/02/01 20:34:30, Andi Albrecht wrote:
> > If --color is an issue with "hg", could the pager extension cause problems
> too?
> 
> Right. I'll leave that for a follow up change.

[techtonik, 2013-03-15 03:35:47]

Committed as f802d7c33b51edbf3204994fe3ef598273bb3b42
Partially reverted in dbae1475623a9d34f1a51e6d9e5b996e10a8be84

[techtonik, 2013-03-15 03:38:02]

See issue 5671047.