Issue 5616044: Log more information on status_listener.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5616044: Log more information on status_listener. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by M-A

Modified:
14 years, 4 months ago

Reviewers:
Roger Tawa

Visibility:
Public.

More Reviews

Description

Log more information on status_listener. Remove support for buildbot 0.7.12.

Patch Set 1 #

Total comments: 2

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -16 lines)			Patch
	M	codereview/views_chromium.py	View		1 chunk	+16 lines, -16 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Roger Tawa

lgtm One question for my own info below. Did you want to reduce logging in ...

14 years, 4 months ago (2012-02-01 21:26:27 UTC) #2

M-A

14 years, 4 months ago (2012-02-02 01:33:18 UTC) #3

On 2012/02/01 21:26:27, rogerta1 wrote:
> lgtm
> 
> One question for my own info below.  Did you want to reduce logging in
> status_listener?

It increases slightly. It's not a big deal even if I thought so earlier this
week. Even if it is an array of the same build event, it doesn't result in that
much I/O. If it ever becomes an issue, I'll clean this up.

http://codereview.appspot.com/5616044/diff/1/codereview/views_chromium.py
File codereview/views_chromium.py (right):

http://codereview.appspot.com/5616044/diff/1/codereview/views_chromium.py#new...
codereview/views_chromium.py:270: HANDLER_MAP[event](base_url, timestamp,
packet, packet.pop('payload'))
On 2012/02/01 21:26:27, rogerta1 wrote:
> why pop payload?

That's what the code was doing before. In theory it wouldn't be necessary now
but I didn't want to change all the called functions.

Expand All Messages | Collapse All Messages