code review 5615046: lib9: make safe for automatic builds

lib9: make safe for automatic builds

[rsc, 2012-02-01 22:48:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2012-02-01 23:01:28]

LGTM

Didn't realize this stuff was slated to be built automatically.

[bradfitz, 2012-02-01 23:01:39]

LGTM

On Wed, Feb 1, 2012 at 2:48 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> lib9: make safe for automatic builds
>
> Please review this at
http://codereview.appspot.com/**5615046/<http://codereview.appspot.com/5615046/>
>
> Affected files:
>  M src/lib9/Makefile
>  M src/lib9/await.c
>  R src/lib9/fmt/errfmt.c
>  R src/lib9/fork.c
>  M src/lib9/getuser.c
>  M src/lib9/jmp.c
>  M src/lib9/notify.c
>  M src/lib9/rfork.c
>  M src/lib9/windows.c
>
>
> Index: src/lib9/Makefile
> ==============================**==============================**=======
> --- a/src/lib9/Makefile
> +++ b/src/lib9/Makefile
> @@ -85,7 +85,7 @@
>
>  ifeq ($(GOHOSTOS),windows)
>  LIB9OFILES+=\
> -       win32.$O\
> +       windows.$O\
>
>  else
>  LIB9OFILES+=\
> Index: src/lib9/await.c
> ==============================**==============================**=======
> --- a/src/lib9/await.c
> +++ b/src/lib9/await.c
> @@ -1,3 +1,5 @@
> +// +build !windows
> +
>  /*
>  Plan 9 from User Space src/lib9/await.c
> 
http://code.swtch.com/**plan9port/src/tip/src/lib9/**await.c<http://code.swtc...
> Index: src/lib9/fmt/errfmt.c
> ==============================**==============================**=======
> deleted file mode 100644
> --- a/src/lib9/fmt/errfmt.c
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -/*
> - * The authors of this software are Rob Pike and Ken Thompson,
> - * with contributions from Mike Burrows and Sean Dorward.
> - *
> - *     Copyright (c) 2002-2006 by Lucent Technologies.
> - *     Portions Copyright (c) 2004 Google Inc.
> - *
> - * Permission to use, copy, modify, and distribute this software for any
> - * purpose without fee is hereby granted, provided that this entire notice
> - * is included in all copies of any software which is or includes a copy
> - * or modification of this software and in all copies of the supporting
> - * documentation for such software.
> - * THIS SOFTWARE IS BEING PROVIDED "AS IS", WITHOUT ANY EXPRESS OR IMPLIED
> - * WARRANTY.  IN PARTICULAR, NEITHER THE AUTHORS NOR LUCENT TECHNOLOGIES
> - * NOR GOOGLE INC MAKE ANY REPRESENTATION OR WARRANTY OF ANY KIND
> CONCERNING
> - * THE MERCHANTABILITY OF THIS SOFTWARE OR ITS FITNESS FOR ANY PARTICULAR
> PURPOSE.
> - */
> -
> -#include <u.h>
> -#include <libc.h>
> -#include "fmtdef.h"
> -
> -int
> -__errfmt(Fmt *f)
> -{
> -       char *s;
> -
> -       s = strerror(errno);
> -       return fmtstrcpy(f, s);
> -}
> Index: src/lib9/fork.c
> ==============================**==============================**=======
> deleted file mode 100644
> --- a/src/lib9/fork.c
> +++ /dev/null
> @@ -1,46 +0,0 @@
> -/*
> -Plan 9 from User Space src/lib9/fork.c
>
-http://code.swtch.com/**plan9port/src/tip/src/lib9/**fork.c<http://code.swtch.com/plan9port/src/tip/src/lib9/fork.c>
> -
> -Copyright 2001-2007 Russ Cox.  All Rights Reserved.
> -
> -Permission is hereby granted, free of charge, to any person obtaining a
> copy
> -of this software and associated documentation files (the "Software"), to
> deal
> -in the Software without restriction, including without limitation the
> rights
> -to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> -copies of the Software, and to permit persons to whom the Software is
> -furnished to do so, subject to the following conditions:
> -
> -The above copyright notice and this permission notice shall be included in
> -all copies or substantial portions of the Software.
> -
> -THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> -IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> -FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> THE
> -AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> -LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> FROM,
> -OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> -THE SOFTWARE.
> -*/
> -#include <u.h>
> -#include <signal.h>
> -#include <libc.h>
> -#include "9proc.h"
> -#undef fork
> -
> -int
> -p9fork(void)
> -{
> -       int pid;
> -       sigset_t all, old;
> -
> -       sigfillset(&all);
> -       sigprocmask(SIG_SETMASK, &all, &old);
> -       pid = fork();
> -       if(pid == 0){
> -               _clearuproc();
> -               _p9uproc(0);
> -       }
> -       sigprocmask(SIG_SETMASK, &old, nil);
> -       return pid;
> -}
> Index: src/lib9/getuser.c
> ==============================**==============================**=======
> --- a/src/lib9/getuser.c
> +++ b/src/lib9/getuser.c
> @@ -1,3 +1,5 @@
> +// +build !windows
> +
>  /*
>  Plan 9 from User Space src/lib9/getuser.c
> 
http://code.swtch.com/**plan9port/src/tip/src/lib9/**getuser.c<http://code.sw...
> Index: src/lib9/jmp.c
> ==============================**==============================**=======
> --- a/src/lib9/jmp.c
> +++ b/src/lib9/jmp.c
> @@ -1,3 +1,5 @@
> +// +build !windows
> +
>  /*
>  Plan 9 from User Space src/lib9/jmp.c
> 
http://code.swtch.com/**plan9port/src/tip/src/lib9/**jmp.c<http://code.swtch....
> Index: src/lib9/notify.c
> ==============================**==============================**=======
> --- a/src/lib9/notify.c
> +++ b/src/lib9/notify.c
> @@ -1,3 +1,5 @@
> +// +build !windows
> +
>  /*
>  Plan 9 from User Space src/lib9/notify.c
> 
http://code.swtch.com/**plan9port/src/tip/src/lib9/**notify.c<http://code.swt...
> Index: src/lib9/rfork.c
> ==============================**==============================**=======
> --- a/src/lib9/rfork.c
> +++ b/src/lib9/rfork.c
> @@ -1,3 +1,5 @@
> +// +build !windows
> +
>  /*
>  Plan 9 from User Space src/lib9/rfork.c
> 
http://code.swtch.com/**plan9port/src/tip/src/lib9/**rfork.c<http://code.swtc...
> Index: src/lib9/windows.c
> ==============================**==============================**=======
> rename from src/lib9/win32.c
> rename to src/lib9/windows.c
>
>
>

[rsc, 2012-02-01 23:25:43]

*** Submitted as http://code.google.com/p/go/source/detail?r=5588ff80d523 ***

lib9: make safe for automatic builds

R=golang-dev, adg, bradfitz
CC=golang-dev
http://codereview.appspot.com/5615046

[rsc, 2012-02-01 23:29:07]

On Wed, Feb 1, 2012 at 18:01,  <adg@golang.org> wrote:
> Didn't realize this stuff was slated to be built automatically.

Yesterday morning, it wasn't.