Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 5610047: [#30039] Fix SCons build on Fedora where Python is compiled with --wide-char ABI (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by techtonik
Modified:
12 years ago
Reviewers:
sergey.vfx, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

http://projects.blender.org/tracker/?func=detail&atid=127&aid=30039&group_id=9

Patch Set 1 #

Patch Set 2 : More explicit #

Patch Set 3 : Remove unnecessary comments #

Patch Set 4 : Working version #

Patch Set 5 : Version with autodetection function, which doesn't work for some reason #

Patch Set 6 : ABI autodetection hack for linux-config.py that works #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M build_files/scons/config/linux-config.py View 1 2 3 4 5 2 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 8
techtonik
12 years, 3 months ago (2012-02-01 07:04:12 UTC) #1
techtonik
Finally, working version.
12 years, 3 months ago (2012-02-01 09:11:49 UTC) #2
sergey.vfx
I don't think it's right approach. It shouldn't be per-distro check, it should be automatic ...
12 years, 3 months ago (2012-02-01 18:23:54 UTC) #3
techtonik
I tried to create an autodetection function, but for some reason it doesn't work inside ...
12 years, 3 months ago (2012-02-01 19:43:34 UTC) #4
techtonik
12 years, 3 months ago (2012-02-02 18:40:09 UTC) #5
techtonik
Patch Set 5 fails, and this is very, very confusing: NameError: global name 'BF_PYTHON' is ...
12 years, 3 months ago (2012-02-02 18:41:46 UTC) #6
techtonik
Finally made a patch that works.
12 years ago (2012-04-23 15:44:08 UTC) #7
techtonik
12 years ago (2012-04-23 16:50:48 UTC) #8
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b