code review 5610045: encoding/base64: ignore new line characters during decode.

encoding/base64: ignore new line characters during decode.

Fixes issue 2541.

[dsymonds, 2012-02-01 05:55:58]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-02-01 06:11:22]

http://codereview.appspot.com/5610045/diff/5/src/pkg/encoding/base64/base64.go
File src/pkg/encoding/base64/base64.go (right):

http://codereview.appspot.com/5610045/diff/5/src/pkg/encoding/base64/base64.g...
src/pkg/encoding/base64/base64.go:226: if in == '\r' || in == '\n' {
what are we supposed to do with spaces? too bad this is an internet standard so
we have no way to know what's actually the right thing to do (it amuses me
sardonically that the 'issue' you're addressing is that the code implements the
RFC.)

http://codereview.appspot.com/5610045/diff/5/src/pkg/encoding/base64/base64.g...
src/pkg/encoding/base64/base64.go:228: j--
not a fan of this style. how about instead just taking the j++ out of the loop
header and putting it after this block?

[dsymonds, 2012-02-01 06:15:05]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-02-01 06:19:43]

http://codereview.appspot.com/5610045/diff/5/src/pkg/encoding/base64/base64.go
File src/pkg/encoding/base64/base64.go (right):

http://codereview.appspot.com/5610045/diff/5/src/pkg/encoding/base64/base64.g...
src/pkg/encoding/base64/base64.go:226: if in == '\r' || in == '\n' {
On 2012/02/01 06:11:22, r wrote:
> what are we supposed to do with spaces? too bad this is an internet standard
so
> we have no way to know what's actually the right thing to do (it amuses me
> sardonically that the 'issue' you're addressing is that the code implements
the
> RFC.)

I don't know if spaces matter much. \r and \n crop up because various situations
automatically wrap base64, but they don't normally insert spaces. I think it's
fine to leave spaces as bad input at least for now.

http://codereview.appspot.com/5610045/diff/5/src/pkg/encoding/base64/base64.g...
src/pkg/encoding/base64/base64.go:228: j--
On 2012/02/01 06:11:22, r wrote:
> not a fan of this style. how about instead just taking the j++ out of the loop
> header and putting it after this block?

It's got to go at the bottom of the loop, but done.

[r, 2012-02-01 08:07:54]

LGTM

[dsymonds, 2012-02-01 08:13:46]

*** Submitted as http://code.google.com/p/go/source/detail?r=e9677eca3648 ***

encoding/base64: ignore new line characters during decode.

Fixes issue 2541.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5610045

[rsc, 2012-02-02 22:18:32]

Thank you.  Please do the same to base32.